Ticket #463 (new defect)

Opened 5 years ago

Last modified 5 years ago

change groupnames when importing events

Reported by: janneke@… Owned by: s.h.sikkema@…
Priority: minor Milestone: 0.8.6
Component: Import wizard Version: 0.8.2
Keywords: Cc:
Hardware: Operating system:
Product: URL:


When importing events, groupnames are created based on eventname+starttime.
However, usually distinction between groups is not in events, so 1 group of subjects can have multiple events/samplingevents.

So, first time events are created, maybe groupnames should be created like group1, group2. And when I import a second time, the wizard should check and ask me if I want to add subjects+event to existing groups, or create new ones.

Change History

comment:1 Changed 5 years ago by work@…

  • Milestone changed from 0.8.3 to 0.8.4

comment:2 Changed 5 years ago by business@…

This can be overcome by adding all field values to the event group name as well. That will also delineate the unique events that will be created anyway.

comment:3 Changed 5 years ago by business@…

Example: if we have 4 'Organ sampling events', at 2 timepoints 0w and 1w, and 2 'Organ' field values 'liver' and 'intestine', then right now we would get

  • Organ_sampling_0w
  • Organ_sampling_0w
  • Organ_sampling_1w
  • Organ_sampling_1w

I would propose to include field values, i.e.

  • Organ_sampling_liver_0w
  • Organ_sampling_intestine_0w
  • Organ_sampling_liver_1w
  • Organ_sampling_intestine_1w

Make sure the name doesn't go over 255 characters and will be unique (we should probably make a function for that, same functionality is needed when designing sample names in create wizard).

comment:4 Changed 5 years ago by business@…

For all generated group names uniqueness within the study should be ensured.

comment:5 Changed 5 years ago by business@…

  • Milestone changed from 0.8.4 to 0.8.6

comment:6 Changed 5 years ago by business@…

EventGroup? uniqueness seems not be enforced anymore? (get 180+ events when importing the testset from NMC presentatie mei).

comment:7 Changed 5 years ago by business@…

  • Priority changed from major to minor

comment:8 Changed 5 years ago by s.h.sikkema@…

Uniqueness constraint still works when I try it (see ticket #516)
I see a problem with the suggested implementation concerning adding field values to the group names. There can be potentially a lot of field values resulting in long unclear names. Some of the field values are simply '0' or 'null' or timepoints displayed in seconds. Is there another way? Do we need group names at all?

Note: See TracTickets for help on using tickets.