Ticket #329 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Finishing touch after tokens have been refactored

Reported by: robert@… Owned by: work@…
Priority: major Milestone: 0.7.0
Component: Unknown Version: 0.6.3
Keywords: Cc:
Product: Operating system:
URL: Hardware:

Description

The tokens for studies, samples and assays have been replaced by UUIDs recently. However, still some old functionality remains, which should be removed. Proposed changes:

- make study.code non-required
- remove externalAssayId or at least make it non-required
- remove assay code from study view page (assays tab)

Change History

Changed 3 years ago by business@…

  • milestone set to Must have

It's probably a good idea to make the assay name then unique within a study instead. In the UIs of the modules, we need some kind of label to identify assays, study code + assay name is probably the most logical choice for that.

Changed 3 years ago by robert@…

  • status changed from new to assigned
  • owner changed from business@… to robert@…

Changed 3 years ago by business@…

  • milestone changed from Must have to 0.7

Changed 3 years ago by robert@…

  • owner changed from robert@… to work@…

See r1594. Jeroen, would you check whether I have implemented the database upgrade script correctly?

Changed 3 years ago by work@…

  • status changed from assigned to closed
  • resolution set to fixed

The upgrade method looks good, however it now tries to alter the table every time it is run. It would probably be better to include a query to see if the table needs to be altered at all. Same for earlier additions to the upgrade script.

I added these checks in r1595 and confirmed it to be working properly on the ci database

Note: See TracTickets for help on using tickets.