Ticket #155 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

'Show Studies' page needs to be re-developed

Reported by: work@… Owned by: work@…
Priority: critical Milestone:
Component: General Version:
Keywords: Cc:
Product: Operating system:
URL: Hardware:

Description

Currently the 'show studies' page is a huge legacy page and a total rewrite of this page has been on the shelf before but has been postponed for other priorities. However a total rewrite is now long overdue.

Relates to issues #66 #67 #72 #72 #137

Change History

Changed 3 years ago by robert@…

I'ds suggest to also use ajax loading of tabs (see  http://jqueryui.com/demos/tabs/#ajax), to improve speed.

Changed 3 years ago by robert@…

  • status changed from new to assigned
  • owner set to robert@…

Changed 3 years ago by robert@…

  • owner changed from robert@… to work@…

The study page is rewritten such that all tabs are built up in different views. Those views are only loaded when a user clicks on a tab (except for the first one).

Did you expect other changes?

Changed 3 years ago by robert@…

See r1213 for this change

Changed 3 years ago by work@…

Thanks Robert, it looks indeed better now, with the Ajax loading of tabs :) However, I wonder if the values are right. See  http://ci.gscf.nmcdsp.org/gscf-0.6.0-ci/study/show/355 and then the 'subjects' tab (as admin).

Height and weight have a lot of decimals after the comma, also I see 'weight' twice. When I edit the study I see the same strange values, I wonder of those are indeed proper values. Also, when editting the study I only see the 'weight' field only once. Not sure why it pops up twice in the view study page?

Changed 3 years ago by work@…

  • owner changed from work@… to robert@…

Changed 3 years ago by robert@…

  • owner changed from robert@… to work@…

The double column showed up because both the human and the mouse template contained a templatefield 'weight', but both with another unit (kgs <-> grams). These templatefields were considered different. I've changed the code such that these values are shown in only one column, with the correct unit. See r1224.

This has the consequence that different template fields with the same name (e.g. 'weight') are considered equal when showing data.

The strange values occur because they are entered that way (or maybe computed in the bootstrap, long time ago). If you change the values to a shorter value, it also shows up.

Changed 3 years ago by work@…

  • status changed from assigned to closed
  • resolution set to fixed

Thanks Robert, closing this issue...

Note: See TracTickets for help on using tickets.