Ticket #154 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Enhance template editor template field type chooser

Reported by: business@… Owned by: work@…
Priority: major Milestone: Should have
Component: Template editor Version:
Keywords: Cc:
Product: Operating system:
URL: Hardware:

Description

Right now, the template field type chooser in the template editor contains some quite technical terms (FLOAT, DOUBLE etc.) It would be nice if this chooser can be made a little more user friendly:

  • Group the different options into Text, Numerical, Date and Other
  • Next to each option, display an example (e.g. 8 for Integer, 8.1 (normal precision) for Float, 8.13 (double precision) for Double, etc., 1w for RelTime?, etc.

Change History

Changed 3 years ago by robert@…

  • owner changed from robert@… to business@…
  • status changed from new to assigned

I've added grouping and examples (only for date types and numerical types) to the template editor.

I'd suggest removing int and float from the types, and always use long and float instead. Using both is quite confusing, I think, because the differences (7 digits or 15 digits for float/double, and the max value for int and float) is not really useful for end users.

Changed 3 years ago by business@…

  • owner changed from business@… to robert@…

I think removing int and double is a good suggestion, please implement!

Changed 3 years ago by business@…

I meant removing int and float.

Changed 3 years ago by robert@…

  • owner changed from robert@… to business@…

I've removed both fields from the trunk, and made the long field capable of handling ints.

Changed 3 years ago by business@…

  • status changed from assigned to closed
  • resolution set to fixed

Great! I had to run the following query in the CI database to avoid errors:

UPDATE template_field set templatefieldtype = 'DOUBLE' where templatefieldtype= 'FLOAT';
UPDATE template_field set templatefieldtype = 'LONG' where templatefieldtype= 'INTEGER';

But now it works. And for new installation of course these field types cannot be chosen anymore. The orphan tables in the CI (such as study_template_integer_fields) remain there, but they will get deleted when we do a cleanup. It's a CI not a production database and it won't do any harm. The only drawback is that e.g. INTEGER values have now disappeared (such as Age in subjects in PPS3 study), so we might want to clean up the CI database soon. I guess after the template+study export/import is ready.

Changed 3 years ago by work@…

  • status changed from closed to reopened
  • resolution fixed deleted

Indeed a logical change, but INTEGER and FLOAT are not just in TemplateEntity?, they are also handled in
- the importer
- the wizard taglib
- the template editor

Now code and templates specifically ment to handle INTEGER and FLOAT are still in the project, which should also have been removed / refactored as they do not do anything anymore.

Tjeerd has already fixed the importer, the taglib and template aditor should also be stripped of obsolete logic...

Changed 3 years ago by business@…

  • status changed from reopened to assigned
  • owner changed from business@… to robert@…

Changed 3 years ago by robert@…

  • owner changed from robert@… to work@…

I've removed the templates from the template editor and removed a reference to 'INTEGER' and 'FLOAT' from the taglib.

Changed 3 years ago by work@…

  • status changed from assigned to closed
  • resolution set to fixed

Robert's change was in r1166

Closing issue...

Note: See TracTickets for help on using tickets.