Changeset 861

Timestamp:

Aug 30, 2010, 3:45:44 PM (8 years ago)

Author:

keesvb

Message:

added test for Sample name uniqueness at the validate() stage

Location:

trunk/grails-app/domain/dbnp/studycapturing

Files:

• Sample.groovy (modified) (1 diff)
• Study.groovy (modified) (1 diff)

trunk/grails-app/domain/dbnp/studycapturing/Sample.groovy

@@ -62 +62 @@
                 // This feature is tested by integration test SampleTests.testSampleUniqueNameConstraint
                 name(unique:['parent'])
+
+                // Same, but also when the other sample is not even in the database
+                // This feature is tested by integration test SampleTests.testSampleUniqueNameConstraintAtValidate
+                name(validator: { field, obj, errors ->
+                        // 'obj' refers to the actual Sample object
+
+                        // define a boolean
+                        def error = false
+
+                        if (obj.parent) {
+
+                                // check if there is exactly one sample with this name in the study (this one)
+                                if (obj.parent.samples.findAll{ it.name == obj.name}.size() > 1) {
+                                        error = true
+                                        errors.rejectValue(
+                                                'name',
+                                                'sample.UniqueNameViolation',
+                                                [obj.name, obj.parent] as Object[],
+                                                'Sample name {0} appears multiple times in study {1}'
+                                                )
+                                }
+                        }
+                        else {
+                                // if there is no parent study defined, fail immediately
+                                error = true
+                        }
+
+                        // got an error, or not?
+                        return (!error)
+                })
         }
 

trunk/grails-app/domain/dbnp/studycapturing/Study.groovy

@@ -82 +82 @@
          */
         def String toString() {
-                return title
+                return code + " - " + title
         }