Changeset 621 for trunk/src

Timestamp:

Jun 25, 2010, 2:03:22 PM (13 years ago)

Author:

jahn

Message:

Added java.net.URLEncoder.encode() to protect URL parameters.

File:

• trunk/src/groovy/dbnp/rest/CommunicationManager.groovy (modified) (6 diffs)

trunk/src/groovy/dbnp/rest/CommunicationManager.groovy

@@ -4 +4 @@
 import java.util.List
 import java.util.HashMap
+import java.net.URLEncoder
 import grails.converters.JSON
 import org.codehaus.groovy.grails.web.json.*
@@ -37 +38 @@
     def static ServerURL = "http://nbx5.nugo.org/sam"
     def static RestServerURL = ServerURL + "/rest"
+    def static Encoding = "UTF-8" 
 
 
     /* Methods implemented for CleanDataLayer */
-
 
 
@@ -73 +74 @@
      */
     public Object getFeatures() {
-    //    return  request( "features" ) 
+        //    return  request( "features" ) 
         return  getStudiesForKeyword("ldl")
     }
@@ -150 +151 @@
 
     /**
-     * Convenience method for constructing URLs for SAM that need parameters 
+     * Convenience method for constructing URLs for SAM that need parameters.
+     * Note that parameters are first convereted to strings by calling their toString() method
+     * and then Encoded to protect special characters.
      *
      * @params String resource The name of the resource, e.g. importer/pages 
@@ -161 +164 @@
                 params.each { name, value ->
                         if(first) {
-                                first = false                                     // this needs to be protected, otherwise might break url
-                                url += '/nil?' + name + "='" + value.toString() + "'"    
+                                first = false
+                                url += '/nil?' + name + "=" + URLEncoder.encode( value.toString(), Encoding )
                         }
                         else { 
-                                url += '&' + name + "='" + value.toString() + "'"    
+                                url += '&' + name + "=" + URLEncoder.encode( value.toString(), Encoding  )
                         }
                 }
@@ -224 +227 @@
     }
 
-
 }