Changeset 488

Timestamp:

May 27, 2010, 4:10:12 PM (10 years ago)

Author:

duh

Message:

• tweaked termEditorController (set lines in the proper order, error() and success() should always be called last) and removed debugging feedback
• added PostgreSQL optimization comment to datasource

Location:

trunk/grails-app

Files:

• conf/DataSource.groovy (modified) (1 diff)
• controllers/dbnp/studycapturing/TermEditorController.groovy (modified) (4 diffs)

trunk/grails-app/conf/DataSource.groovy

@@ -64 +64 @@
                         url = "jdbc:postgresql://localhost:5432/gscf"
                         dialect = org.hibernate.dialect.PostgreSQLDialect
-                        logSql = true
+                        logSql = true   // enable logging while not yet final
+
+                        /* Apparently Hibernate performs two queries on inserting, one before
+                         * to generate the unique id, and then the insert itself. In PostgreSQL
+                         * > 8.2 this behaviour has changed, however hibernate has not implemented
+                         * this change. In case we might optimize in the future, more info is here:
+                         * http://blog.wolfman.com/articles/2009/11/11/using-postgresql-with-grails
+                         * - Jeroen
+                         */
 
                         // MySQL

trunk/grails-app/controllers/dbnp/studycapturing/TermEditorController.groovy

@@ -48 +48 @@
                                         flow.ontologiesList[ flow.ontologies.size() ] = ncboId
                                 }
-
-                                /*** EXAMPLE OF HOW TO FETCH ONTOLOGY INSTANCES
-                                 * ontologies.each() {
-                                 *       println Ontology.findAllByNcboId( it )
-                                 * }
-                                 */
                         }
                 }
@@ -61 +55 @@
                         render(view: "terms")
                         onRender {
-                                println "Rendering term selection popup"
+                                println ".rendering term selection popup"
                         }
                         on("add") {
-                                println params
                                 def ontology = Ontology.findByNcboVersionedId( params.get('term-ontology_id') as int )
                 def strTerm = params.get('term')
@@ -72 +65 @@
                                         // TODO: if ontology is missing, create it
                     // pending possible addition to OntoCAT BioportalOntologyService API of search by versioned Ontology Id
-                    println "Ontology is empty"
                                 }
 
@@ -84 +76 @@
                                 // validate term
                                 if (term.validate()) {
-                                        println "Term validated correctly"
+                                        // save the term to the database
                                         if (term.save(flush:true)) {
-                                                println ".term save ok"
+                                                flash.message = "Term addition succeeded"
+                                                success()
                                         } else {
-                                                println ".term save failed?"
+                                                flash.message = "Oops, we encountered a problem while storing the selected term. Please try again."
+                                                error()
                                         }
-                                        success()
-                    flash.message = "Term addition succeeded"
                                 } else {
-                                        println "Term validation failed"
-                                        println "errors:"
-                                        term.errors.getAllErrors().each() {
-                                                println it
-                                        }
+                                        // term did not validate properly
+                                        flash.message = "Oops, we encountered a problem while storing the selected term. Please try again."
                                         error()
-                    flash.message = "Term addition failed"
                                 }
                         }.to "terms"