Changeset 298

Timestamp:

Mar 22, 2010, 2:30:51 PM (14 years ago)

Author:

duh

Message:

• table editor did not properly de-attach event handlers properly when unselecting rows

File:

• trunk/web-app/js/table-editor.js (modified) (6 diffs)

trunk/web-app/js/table-editor.js

@@ -52 +52 @@
         $(table).selectable({
             filter: this.rowIdentifier,
-            stop: function() {
-                // remember selected rows
-                that.selected = $('.ui-selected', table);
-
-                // bind on change to columns in rows
-                that.selected.each(function() {
-                    that.attachColumnHandlers(this,table);
-                })
+            selected: function(event, ui) {
+                that.attachColumnHandlers(ui.selected);
+            },
+            unselected: function(event, ui) {
+                that.deAttachColumnHandlers(ui.selected);
             }
         });
@@ -65 +62 @@
 
     /**
+     * de-attach input handlers for this row
+     * @param row
+     */
+    deAttachColumnHandlers: function(row) {
+        var that = this;
+
+        $(this.columnIdentifier, row).each(function() {
+            var input = $(':input', $(this));
+
+            // does this column contain an input field
+            if (input) {
+                // unbind table editor event handlers
+                $(input).unbind('.tableEditor');
+            }            
+        });
+    },
+
+    /**
      * attach handlers to the input elements in a table row
      * @param row
      */
-    attachColumnHandlers: function(row,table) {
+    attachColumnHandlers: function(row) {
         var that = this;
         var count = 0;
@@ -75 +90 @@
         var regAutoComplete = new RegExp("ui-autocomplete-input");
 
-        $(this.columnIdentifier, $(row)).each(function() {
+        $(this.columnIdentifier, row).each(function() {
             var input = $(':input', $(this));
+
             // does this column contain an input field
             if (input) {
@@ -91 +107 @@
                         if (regAutoComplete.test(inputElement.attr('class'))) {
                             // this is a jquery-ui autocomplete field
-                            inputElement.bind('autocompleteclose', function() {
+                            inputElement.bind('autocompleteclose.tableEditor', function() {
                                 // TODO: autocompletion deselects rows... which is what we don't want
                                 //       to happen of course...
                                 that.updateSingleInputElements(input, columnNumber, 'input');
-                            })
+                            });
                         } else {
                             // regular text element
-                            inputElement.bind('keyup', function() {
+                            inputElement.bind('keyup.tableEditor', function() {
                                 that.updateSingleInputElements(input, columnNumber, 'input');
                             });
@@ -106 +122 @@
                         // single select
                         var columnNumber = count;
-                        inputElement.bind('change', function() {
+                        inputElement.bind('change.tableEditor', function() {
                             that.updateSingleInputElements(input, columnNumber, 'select');
                         });
@@ -113 +129 @@
                         // checkbox
                         var columnNumber = count;
-                        inputElement.bind('click', function() {
+                        inputElement.bind('click.tableEditor', function() {
                             that.updateSingleInputElements(input, columnNumber, 'input');
                         });