Changeset 2120 for trunk/grails-app/services/dbnp

Timestamp:

Nov 25, 2011, 3:36:45 PM (11 years ago)

Author:

s.h.sikkema@…

Message:

# GDT

• fixed issue where dynamically populated template select boxes would open pop-up on wrong option
• gdt version 0.1.9

# GDT Importer

• fixed bug in gdtImporter where importer would hang when first choosing sample as data type and then changing to some other data type to import
• when there are errors in the import, table editor is now always enabled (can be really slow still!)
• changed text message under data preview
• fixed bug where going from page 2 to 1 would show all rows instead of just 5
• replaced "Please make any adjustments if required" with "The following data will be imported" when user can't change anything
• removed space between import preview and next button
• gdtImporter version 0.4.6.7

# GSCF

• now includes sampletokens when retrieving assay data from modules to ensure match between data and samples (was mixed up!)

Location:

trunk/grails-app/services/dbnp

Files:

• modules/ModuleCommunicationService.groovy (modified) (2 diffs)
• studycapturing/AssayService.groovy (modified) (4 diffs)

trunk/grails-app/services/dbnp/modules/ModuleCommunicationService.groovy

@@ -183 +183 @@
                 // Store the response in cache
                 storeInCache( restUrl, restResponse, args );
-                
+
                 return restResponse
 
@@ -205 +205 @@
                 def user = authenticationService.getLoggedInUser();
                 def userId = user ? user.id : -1;
-                
+
                 url = cacheUrl( url, args )
                 

trunk/grails-app/services/dbnp/studycapturing/AssayService.groovy

@@ -171 +171 @@
 
                 // Find samples and sort by name
-                if( !samples )
-                        samples = assay.samples.toList().sort { it.name }
+                if ( !samples ) samples = assay.samples.toList()
+                samples = samples.sort { it.name }
 
                 def eventFieldMap = [:]
@@ -194 +194 @@
                         } catch (e) {
                                 moduleMeasurementData = ['error' : ['Module error, module not available or unknown assay'] * samples.size() ]
+                                e.printStackTrace()
                                 moduleError =  e.message
                         }
@@ -311 +312 @@
                 def query = "assayToken=$assay.assayUUID$tokenString"
 
+                if (samples) {
+                         query += '&' + samples*.sampleUUID.collect { "sampleToken=$it" }.join('&')
+                }
+
                 def sampleTokens = [], measurementTokens = [], moduleData = []
 
@@ -316 +321 @@
                         (sampleTokens, measurementTokens, moduleData) = moduleCommunicationService.callModuleMethod(moduleUrl, path, query, "POST", remoteUser)
                 } catch (e) {
+                        e.printStackTrace()
                         throw new Exception("An error occured while trying to get the measurement data from the $assay.module.name. \
              This means the module containing the measurement data is not available right now. Please try again \