Changeset 1373 for trunk/grails-app/domain

Timestamp:

Jan 12, 2011, 2:42:06 PM (10 years ago)

Author:

business@…

Message:

added extra check in sample validation to avoid NPEs in case of broken Study objects

File:

• trunk/grails-app/domain/dbnp/studycapturing/Sample.groovy (modified) (1 diff)

trunk/grails-app/domain/dbnp/studycapturing/Sample.groovy

@@ -82 +82 @@
                         def error = false
 
+                        // check whether obj.parent.samples is not null at this stage to avoid null pointer exception
                         if (obj.parent) {
 
-                                // check if there is exactly one sample with this name in the study (this one)
-                                if (obj.parent.samples.findAll{ it.name == obj.name}.size() > 1) {
-                                        error = true
-                                        errors.rejectValue(
-                                                'name',
-                                                'sample.UniqueNameViolation',
-                                                [obj.name, obj.parent] as Object[],
-                                                'Sample name {0} appears multiple times in study {1}'
-                                                )
+                                if (obj.parent.samples) {
+
+                                        // check if there is exactly one sample with this name in the study (this one)
+                                        if (obj.parent.samples.findAll{ it.name == obj.name}.size() > 1) {
+                                                error = true
+                                                errors.rejectValue(
+                                                        'name',
+                                                        'sample.UniqueNameViolation',
+                                                        [obj.name, obj.parent] as Object[],
+                                                        'Sample name {0} appears multiple times in study {1}'
+                                                        )
+                                        }
                                 }
                         }