Changeset 1167

Timestamp:

Nov 18, 2010, 12:13:07 PM (12 years ago)

Author:

robert@…

Message:

Added a check for string template fields, because they can not exceed 255 characters. See ticket #193

Location:

trunk/grails-app

Files:

• domain/dbnp/studycapturing/TemplateEntity.groovy (modified) (1 diff)
• i18n/messages.properties (modified) (1 diff)

trunk/grails-app/domain/dbnp/studycapturing/TemplateEntity.groovy

@@ -94 +94 @@
                         fields.each { key, value ->
                                 // check if the value is of proper type
-                                if (value && value.class != String) {
-                                        // it's of some other type
-                                        try {
-                                                // try to cast it to the proper type
-                                                fields[key] = (value as String)
-                                        } catch (Exception e) {
-                                                // could not typecast properly, value is of improper type
-                                                // add error message
+                                if (value) {
+                                        def strValue = "";
+                                        if( value.class != String) {
+                                                // it's of some other type
+                                                try {
+                                                        // try to cast it to the proper type
+                                                        strValue = (value as String)
+                                                        fields[key] = strValue
+                                                } catch (Exception e) {
+                                                        // could not typecast properly, value is of improper type
+                                                        // add error message
+                                                        error = true
+                                                        errors.rejectValue(
+                                                                'templateStringFields',
+                                                                'templateEntity.typeMismatch.string',
+                                                                [key, value.class] as Object[],
+                                                                'Property {0} must be of type String and is currently of type {1}'
+                                                        )
+                                                }
+                                        } else {
+                                                strValue = value;
+                                        }
+
+                                        // Check whether the string doesn't exceed 255 characters
+                                        if( strValue.size() > 255 ) {
                                                 error = true
                                                 errors.rejectValue(
                                                         'templateStringFields',
-                                                        'templateEntity.typeMismatch.string',
-                                                        [key, value.class] as Object[],
-                                                        'Property {0} must be of type String and is currently of type {1}'
+                                                        'templateEntity.tooLong.string',
+                                                        [key] as Object[],
+                                                        'Property {0} may contain at most 255 characters.'
                                                 )
                                         }

trunk/grails-app/i18n/messages.properties

@@ -58 +58 @@
 templateEntity.typeMismatch.integer=Property {0} must be of type Integer and is currently of type {1}
 templateEntity.typeMismatch.string=Property {0} must be of type String and is currently of type {1}
+templateEntity.tooLong.string=Property {0} may contain at most 255 characters.
 templateEntity.typeMismatch.templateFieldListItem=Property {0} must be of type TemplateFieldListItem and is currently of type {1}
 templateEntity.typeMismatch.float=Property {0} must be of type Float and is currently of type {1}