Ticket #66 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

getMeasurementData REST interface does not implement 'verbose' argument

Reported by: work@… Owned by: m.s.vanvliet@…
Priority: major Milestone:
Component: RESTful GET methods Version:
Keywords: Cc:

Description

In contrast to the SAM and Metagenomics modules, the metabolomics module does not correctly implement the _verbose_ argument.

Regardless if the _verbose_ argument is set to true or to false, the result is always:

[
[
"76ffc208-229f-4c57-8f05-3957a5b71276",
"d119fe48-94a1-414b-acb7-10ff99e2c0ee",
"ced19e94-f0b8-43e1-bada-27b217fa12fa",
"495b22b7-7c76-4c3b-8a91-48095ee76d5c",
"3e7f1bb3-1605-4a28-b39b-1ba3feb6f06b",
"12315c72-541d-40b2-ae0a-7b25927113d3",
"47ed2d81-8b33-4d76-b5f8-9db5ffeb790f",
"ff8429f1-c49c-47d8-bfa6-f4af3a6d0587",
"180df6e2-758f-462e-b87f-1dc17227a9f8",
"53eb0b24-6349-4439-9934-badbb5990c65",
"310e9b32-2280-4e7d-8b56-74f9a34802e8",
"bcbaef0f-fede-4f4e-923b-aa350cd4872b",
"c7f1d773-d80c-4b59-a46e-b381c24205eb",
"7a5a8bbb-bd13-4245-acdf-1a16287ca6a1",
"b0ea46f9-d2e3-4d22-9841-13d5c615f3a5",
"9458c9a9-2999-4412-a190-43f5f5a6cbcd",
"6eced435-f292-4610-abad-fcea41519b63",
"b6b8948a-bd66-4acf-95bb-e99548264dc1",
"dad82e3f-06e9-42ee-8a22-864971bdf11b",
"5d347e25-bd22-4772-8320-0561d76770dd"
],
[
"PA(12:0/13:0)",
"PA(16:0/18:1(9Z))"
],
[
123,
789,
111,
314,
214,
414,
324,
311,
214,
315,
316,
456,
101,
121,
151,
251,
331,
155,
451,
251,
131,
251
]
]

According to the API spec at  http://dbnp.org/dbnp/modules-1/detailed-descriptions-of-restful-services the _verbose=false_ argument should return an array with 3 sub-arrays containing
(1) a list of sampleTokens,
(2) a list of measurementTokens,
(3) a list of values

While the _verbose=true_ should return one array containing all samples and their measurements. See below for examples taken from SAM.

Example SAM reply with verbose=true:

[
{
"measurementToken":
"Fat Depot",
"sampleToken":
"a4d16db8-49f2-4dc2-81bb-910e574c804a",
"value":
311
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"6bfe2a0d-3af0-4ed8-8144-56840e934f6e",
"value":
456
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"c180d727-8d6c-4673-a5fd-1c28f04b8aaa",
"value":
347
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"4edff5ad-c3af-41da-8efe-87f5a018912a",
"value":
368
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"07378e29-3233-4e3f-b4ea-007f9f9b1317",
"value":
310
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"4861fc77-1320-4401-b18a-66b1cd67d2c8",
"value":
411
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"f7392df1-a754-4957-a1d0-c98bbb91080d",
"value":
318
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"a556b145-dd37-4568-92f1-e3a251653276",
"value":
1150
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"2c719340-eb7f-4a70-8527-c64cc74dc542",
"value":
1039
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"775666dd-05b1-4f35-ac9c-d36f8257eb1a",
"value":
2075
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"fc755220-b2b4-43ed-adf8-e4323fc62b55",
"value":
1308
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"198183b1-d402-4f24-9c5a-396f79bb6a55",
"value":
1918
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"e888b1b1-1dc8-45ed-8196-00338fa3b36f",
"value":
1387
},
{
"measurementToken":
"Fat Depot",
"sampleToken":
"7e9930bc-ec8c-4e74-bd2b-49d6c852eeda",
"value":
945
}
]

Example SAM reply with verbose=false:

[
[
"a4d16db8-49f2-4dc2-81bb-910e574c804a",
"6bfe2a0d-3af0-4ed8-8144-56840e934f6e",
"c180d727-8d6c-4673-a5fd-1c28f04b8aaa",
"4edff5ad-c3af-41da-8efe-87f5a018912a",
"07378e29-3233-4e3f-b4ea-007f9f9b1317",
"4861fc77-1320-4401-b18a-66b1cd67d2c8",
"f7392df1-a754-4957-a1d0-c98bbb91080d",
"a556b145-dd37-4568-92f1-e3a251653276",
"2c719340-eb7f-4a70-8527-c64cc74dc542",
"775666dd-05b1-4f35-ac9c-d36f8257eb1a",
"fc755220-b2b4-43ed-adf8-e4323fc62b55",
"198183b1-d402-4f24-9c5a-396f79bb6a55",
"e888b1b1-1dc8-45ed-8196-00338fa3b36f",
"7e9930bc-ec8c-4e74-bd2b-49d6c852eeda"
],
[
"Fat Depot"
],
[
311,
456,
347,
368,
310,
411,
318,
1150,
1039,
2075,
1308,
1918,
1387,
945
]
]

So, the metabolomics module seems to always return data in the _verbose=false_ format.

Michael, is this something you can fix?

Change History

Changed 2 years ago by work@…

note: related to #65

Changed 2 years ago by work@…

The debugging call debugModuleDataForAssay now returns more debugging information:
1. getMeasurementData REST call (verbose=true)
2. getMeasurementData REST call (verbose=false)
3. getMeasurements REST call
4. getMeasurementMetaData REST call

see:  http://ci.nmcdsp.org/api/debugModuleDataForAssay?deviceID=123&assayToken=6f2558db-a20c-4e6a-8d86-49391ca1aed1

Changed 2 years ago by m.s.vanvliet@…

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.