Changeset 17

Timestamp:

Feb 28, 2011, 1:49:07 PM (12 years ago)

Author:

robert@…

Message:

Better error handling during synchronization

Location:

trunk/grails-app

Files:

• controllers/nl/tno/metagenomics/integration/SynchronizeController.groovy (modified) (1 diff)
• views/synchronize/full.gsp (modified) (2 diffs)

trunk/grails-app/controllers/nl/tno/metagenomics/integration/SynchronizeController.groovy

@@ -30 +30 @@
                 } catch( Exception e ) {
                         // Catch all exceptions, show them to the user (by rendering a text message) and print a stacktrace
-                        log.error "Exception during full synchronization: " + e.getMessage()
+                        def message = e.getMessage();
+                        if( !message || message == 'null' )
+                                message = 'unknown error';
+                
+                        // Show errors in log file              
+                        log.error "Exception during full synchronization: " + message
                         e.printStackTrace()
                         
-                        render "An error occurred during synchronization (" + e.class?.name + "): " + e.getMessage();
+                        // Give the user a nice error message
+                        response.status = 500;
+                        render "An error occurred during synchronization (" + e.class?.name + "): " + message;
                 }
         }

trunk/grails-app/views/synchronize/full.gsp

@@ -23 +23 @@
                                   success: function(data) { window.location.replace( "${url.encodeAsJavaScript()}" ); },
                                   error: function(xhr, textStatus, errorThrown) { 
-                                        if( confirm( "Error " + xhr.responseCode + ": " + xhr.responseText + ". Would you like to try again?" ) ) {
-                                                window.location.refresh();
+                                        if( confirm( xhr.responseText + ". Please contact the system administrator if the problem persists. Would you like to try again?" ) ) {
+                                                window.location.reload(true);
                                         } else {
-                                                alert( "Redirect to: ${url.encodeAsJavaScript()}" );
+                                                /*
                                                 if( confirm( "Would you like to continue to the original page?") ) {
                                                         window.location.replace( "${url.encodeAsJavaScript()}" );
@@ -32 +32 @@
                                                         $( "#wait_dialog").dialog( "close" );
                                                 }
+                                                */
+                                                $( "#wait_dialog").dialog( "close" );
                                         }                                               
                                   }